Commit 3ac8eed6 authored by Gerhard Engleder's avatar Gerhard Engleder Committed by David S. Miller
Browse files

net: phy: Uniform PHY driver access 



struct phy_device contains a pointer to the PHY driver and nearly
everywhere this pointer is used to access the PHY driver. Only
mdio_bus_phy_may_suspend() is still using to_phy_driver() instead of the
PHY driver pointer. Uniform PHY driver access by eliminating
to_phy_driver() use in mdio_bus_phy_may_suspend().

Only phy_bus_match() and phy_probe() are still using to_phy_driver(),
because PHY driver pointer is not available there.

Signed-off-by: default avatarGerhard Engleder <gerhard@engleder-embedded.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4ed311b0

drivers/net/phy/phy_device.c

+1 −3
Original line number Diff line number Diff line
@@ -233,11 +233,9 @@ static DEFINE_MUTEX(phy_fixup_lock); 


static bool mdio_bus_phy_may_suspend(struct phy_device *phydev)

{

	struct device_driver *drv = phydev->mdio.dev.driver;

	struct phy_driver *phydrv = to_phy_driver(drv);

	struct net_device *netdev = phydev->attached_dev;



	if (!drv || !phydrv->suspend)

	if (!phydev->drv->suspend)

		return false;



	/* PHY not attached? May suspend if the PHY has not already been