Commit 3ab4ce2d authored by Wei Yongjun's avatar Wei Yongjun Committed by Wolfram Sang
Browse files

i2c: designware: Fix return value check in navi_amd_register_client() 



In case of error, the function i2c_new_client_device() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().

Fixes: 17631e8c ("i2c: designware: Add driver support for AMD NAVI GPU")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Acked-by: default avatarJarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent 010e32ab

drivers/i2c/busses/i2c-designware-pcidrv.c

+2 −2
Original line number Diff line number Diff line
@@ -132,8 +132,8 @@ static int navi_amd_register_client(struct dw_i2c_dev *dev) 
	info.irq = dev->irq;



	dev->slave = i2c_new_client_device(&dev->adapter, &info);

	if (!dev->slave)

		return -ENODEV;

	if (IS_ERR(dev->slave))

		return PTR_ERR(dev->slave);



	return 0;

}