Commit 3aac630b authored Jan 12, 2021 by Eric Biggers Committed by Jan Kara Jan 13, 2021

gfs2: don't worry about I_DIRTY_TIME in gfs2_fsync()

The I_DIRTY_TIME flag is primary used within the VFS, and there's no
reason for ->fsync() implementations to do anything with it.  This is
because when !datasync, the VFS will expire dirty timestamps before
calling ->fsync().  (See vfs_fsync_range().)  This turns I_DIRTY_TIME
into I_DIRTY_SYNC.

Therefore, change gfs2_fsync() to not check for I_DIRTY_TIME.

Link: https://lore.kernel.org/r/20210112190253.64307-11-ebiggers@kernel.org


Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Jan Kara <jack@suse.cz>

parent da0c4c60

fs/gfs2/file.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -749,7 +749,7 @@ static int gfs2_fsync(struct file *file, loff_t start, loff_t end,
		{
		struct address_space *mapping = file->f_mapping;
		struct inode *inode = mapping->host;
		int sync_state = inode->i_state & I_DIRTY_ALL;
		int sync_state = inode->i_state & I_DIRTY;
		struct gfs2_inode *ip = GFS2_I(inode);
		int ret = 0, ret1 = 0;

		@@ -762,7 +762,7 @@ static int gfs2_fsync(struct file *file, loff_t start, loff_t end,
		if (!gfs2_is_jdata(ip))
		sync_state &= ~I_DIRTY_PAGES;
		if (datasync)
		sync_state &= ~(I_DIRTY_SYNC \| I_DIRTY_TIME);
		sync_state &= ~I_DIRTY_SYNC;

		if (sync_state) {
		ret = sync_inode_metadata(inode, 1);