Commit 3aa0a80f authored by Boris Brezillon's avatar Boris Brezillon
Browse files

drm/panfrost: Clear MMU irqs before handling the fault 



When a fault is handled it will unblock the GPU which will continue
executing its shader and might fault almost immediately on a different
page. If we clear interrupts after handling the fault we might miss new
faults, so clear them before.

Cc: <stable@vger.kernel.org>
Fixes: 187d2929 ("drm/panfrost: Add support for GPU heap allocations")
Signed-off-by: default avatarBoris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: default avatarSteven Price <steven.price@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210205111757.585248-2-boris.brezillon@collabora.com
parent 10073770

drivers/gpu/drm/panfrost/panfrost_mmu.c

+2 −2
Original line number Diff line number Diff line
@@ -593,6 +593,8 @@ static irqreturn_t panfrost_mmu_irq_handler_thread(int irq, void *data) 
		access_type = (fault_status >> 8) & 0x3;

		source_id = (fault_status >> 16);



		mmu_write(pfdev, MMU_INT_CLEAR, mask);



		/* Page fault only */

		ret = -1;

		if ((status & mask) == BIT(i) && (exception_type & 0xF8) == 0xC0)
@@ -616,8 +618,6 @@ static irqreturn_t panfrost_mmu_irq_handler_thread(int irq, void *data) 
				access_type, access_type_name(pfdev, fault_status),

				source_id);



		mmu_write(pfdev, MMU_INT_CLEAR, mask);



		status &= ~mask;

	}