Commit 3a98990a authored by Muchun Song's avatar Muchun Song Committed by Linus Torvalds
Browse files

mm/memcontrol.c: add missed css_put() 

We should put the css reference when memory allocation failed.

Link: http://lkml.kernel.org/r/20200614122653.98829-1-songmuchun@bytedance.com


Fixes: f0a3a24b ("mm: memcg/slab: rework non-root kmem_cache lifecycle management")
Signed-off-by: default avatarMuchun Song <songmuchun@bytedance.com>
Acked-by: default avatarRoman Gushchin <guro@fb.com>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: Qian Cai <cai@lca.pw>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent cd324edc

mm/memcontrol.c

+3 −1
Original line number Diff line number Diff line
@@ -2772,8 +2772,10 @@ static void memcg_schedule_kmem_cache_create(struct mem_cgroup *memcg, 
		return;



	cw = kmalloc(sizeof(*cw), GFP_NOWAIT | __GFP_NOWARN);

	if (!cw)

	if (!cw) {

		css_put(&memcg->css);

		return;

	}



	cw->memcg = memcg;

	cw->cachep = cachep;