Commit 3a87fc6f authored Apr 04, 2023 by Simon Horman Committed by Mathieu Poirier Apr 05, 2023

remoteproc: pru: Remove always true check positive unsigned value



In both cases the type of da is u32. And PRU_PDRAM_DA is 0.
So the check da >= PRU_PDRAM_DA is always true and can be removed.

Flagged by Smatch:

 drivers/remoteproc/pru_rproc.c:660 pru_d_da_to_va() warn: always true condition '(da >= 0) => (0-u32max >= 0)'
 drivers/remoteproc/pru_rproc.c:709 pru_i_da_to_va() warn: always true condition '(da >= 0) => (0-u32max >= 0)'

No functional changes intended.
Compile tested only.

Reported-by: kernel test robot <lkp@intel.com>
Link: https://www.spinics.net/lists/kernel/msg4025983.html


Signed-off-by: Simon Horman <horms@kernel.org>
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
Link: https://lore.kernel.org/r/20230404-pru-always-true-v1-1-b1b55eeff188@kernel.org


[Fixed typo in changelog]
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>

parent 96af01cd

drivers/remoteproc/pru_rproc.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -657,7 +657,7 @@ static void pru_d_da_to_va(struct pru_rproc pru, u32 da, size_t len)
		swap(dram0, dram1);
		shrd_ram = pruss->mem_regions[PRUSS_MEM_SHRD_RAM2];

		if (da >= PRU_PDRAM_DA && da + len <= PRU_PDRAM_DA + dram0.size) {
		if (da + len <= PRU_PDRAM_DA + dram0.size) {
		offset = da - PRU_PDRAM_DA;
		va = (__force void *)(dram0.va + offset);
		} else if (da >= PRU_SDRAM_DA &&
		@@ -706,8 +706,7 @@ static void pru_i_da_to_va(struct pru_rproc pru, u32 da, size_t len)
		*/
		da &= 0xfffff;

		if (da >= PRU_IRAM_DA &&
		da + len <= PRU_IRAM_DA + pru->mem_regions[PRU_IOMEM_IRAM].size) {
		if (da + len <= PRU_IRAM_DA + pru->mem_regions[PRU_IOMEM_IRAM].size) {
		offset = da - PRU_IRAM_DA;
		va = (__force void *)(pru->mem_regions[PRU_IOMEM_IRAM].va +
		offset);