Commit 3a821a82 authored by Wolfram Sang's avatar Wolfram Sang Committed by Ulf Hansson
Browse files

mmc: renesas_sdhi: complain loudly if driver needs update 



When the tap array in the driver is too low, this is not a warning but
an error. Also _once is not helpful, we should make sure it is
prominently in the logs. It is safe to do this because this will only
show up during SoC enablement when we a new SoCs needs more taps (if
that ever will happen).

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: default avatarNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Link: https://lore.kernel.org/r/20200129203709.30493-3-wsa+renesas@sang-engineering.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 0c482d82

drivers/mmc/host/renesas_sdhi_core.c

+3 −3
Original line number Diff line number Diff line
@@ -499,9 +499,9 @@ static int renesas_sdhi_execute_tuning(struct tmio_mmc_host *host, u32 opcode) 
		return 0; /* Tuning is not supported */



	if (host->tap_num * 2 >= sizeof(host->taps) * BITS_PER_BYTE) {

		dev_warn_once(&host->pdev->dev,

			"Too many taps, skipping tuning. Please consider updating size of taps field of tmio_mmc_host\n");

		return 0;

		dev_err(&host->pdev->dev,

			"Too many taps, please update 'taps' in tmio_mmc_host!\n");

		return -EINVAL;

	}



	priv->doing_tune = true;