Commit 3a26bca3 authored by Srinivas Pandruvada's avatar Srinivas Pandruvada Committed by Yingbao Jia
Browse files

platform/x86: ISST: Reset default callback on unregister 

mainline inclusion
from mainline-v6.4-rc4
commit fa5e68b1
category: feature
bugzilla: https://gitee.com/openeuler/intel-kernel/issues/I8WOEO

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fa5e68b1c10d56befcee2ee0a9e1eed2c830e352



-------------------------------------

When multiple clients are registered and some of those modules are
removed, the default IOCTL callback for those clients are still not
NULL. Calling them will result in crash.

Set the default IOCTL callback pointer to NULL on unregister.

Intel-SIG: commit fa5e68b1 platform/x86: ISST: Reset default callback on unregister.
Backport Intel speed select ISST driver support on TPMI.

Signed-off-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Link: https://lore.kernel.org/r/20230612224033.2382527-2-srinivas.pandruvada@linux.intel.com


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
[ Yingbao Jia: amend commit log ]
Signed-off-by: default avatarYingbao Jia <yingbao.jia@intel.com>
parent b4845ce3

drivers/platform/x86/intel_speed_select_if/isst_if_common.c

+1 −0
Original line number Diff line number Diff line
@@ -829,6 +829,7 @@ void isst_if_cdev_unregister(int device_type) 
{

	isst_misc_unreg();

	mutex_lock(&punit_misc_dev_open_lock);

	punit_callbacks[device_type].def_ioctl = NULL;

	punit_callbacks[device_type].registered = 0;

	if (device_type == ISST_IF_DEV_MBOX)

		isst_delete_hash();