Commit 3a243c2c authored by Luo Jiaxing's avatar Luo Jiaxing Committed by Martin K. Petersen
Browse files

scsi: libsas: Remove postreset from sas_sata_ops 

sas_sata_ops uses ata_std_postreset as .postreset callback. However,
ata_std_postreset() calls sata_scr_read()/sata_scr_write() which need to
access the ATA SCR register. This register not available in the libsas case
and the functions always return -EOPNOTSUPP.

Drop the .postreset callback.

Link: https://lore.kernel.org/r/1595408643-63011-2-git-send-email-luojiaxing@huawei.com


Reviewed-by: default avatarJohn Garry <john.garry@huawei.com>
Reviewed-by: default avatarJason Yan <yanaijie@huawei.com>
Signed-off-by: default avatarLuo Jiaxing <luojiaxing@huawei.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent e3d2bf65

drivers/scsi/libsas/sas_ata.c

+0 −1
Original line number Diff line number Diff line
@@ -510,7 +510,6 @@ void sas_ata_end_eh(struct ata_port *ap) 
static struct ata_port_operations sas_sata_ops = {

	.prereset		= ata_std_prereset,

	.hardreset		= sas_ata_hard_reset,

	.postreset		= ata_std_postreset,

	.error_handler		= ata_std_error_handler,

	.post_internal_cmd	= sas_ata_post_internal,

	.qc_defer               = ata_std_qc_defer,