Commit 3a20f814 authored by Nikita Kiryushin's avatar Nikita Kiryushin Committed by Yang Yingliang
Browse files

rcu-tasks: Fix show_rcu_tasks_trace_gp_kthread buffer overflow

mainline inclusion
from mainline-v6.10-rc1
commit cc5645fddb0ce28492b15520306d092730dffa48
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/IA6SGB
CVE: CVE-2024-38577

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cc5645fddb0ce28492b15520306d092730dffa48



---------------------------

There is a possibility of buffer overflow in
show_rcu_tasks_trace_gp_kthread() if counters, passed
to sprintf() are huge. Counter numbers, needed for this
are unrealistically high, but buffer overflow is still
possible.

Use snprintf() with buffer size instead of sprintf().

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: edf3775f ("rcu-tasks: Add count for idle tasks on offline CPUs")
Signed-off-by: default avatarNikita Kiryushin <kiryushin@ancud.ru>
Reviewed-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
Signed-off-by: default avatarUladzislau Rezki (Sony) <urezki@gmail.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
parent 6fb08040
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -1938,7 +1938,7 @@ void show_rcu_tasks_trace_gp_kthread(void)
{
	char buf[64];

	sprintf(buf, "N%lu h:%lu/%lu/%lu",
	snprintf(buf, sizeof(buf), "N%lu h:%lu/%lu/%lu",
		data_race(n_trc_holdouts),
		data_race(n_heavy_reader_ofl_updates),
		data_race(n_heavy_reader_updates),