Commit 39fa7a95 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe
Browse files

bcache: remove bch_crc64_update 



bch_crc64_update is an entirely pointless wrapper around crc64_be.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarColy Li <colyli@suse.de>
Link: https://lore.kernel.org/r/20211020143812.6403-9-colyli@suse.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 00387bd2

drivers/md/bcache/btree.c

+1 −1
Original line number Diff line number Diff line
@@ -141,7 +141,7 @@ static uint64_t btree_csum_set(struct btree *b, struct bset *i) 
	uint64_t crc = b->key.ptr[0];

	void *data = (void *) i + 8, *end = bset_bkey_last(i);



	crc = bch_crc64_update(crc, data, end - data);

	crc = crc64_be(crc, data, end - data);

	return crc ^ 0xffffffffffffffffULL;

}

drivers/md/bcache/request.c

+1 −1
Original line number Diff line number Diff line
@@ -46,7 +46,7 @@ static void bio_csum(struct bio *bio, struct bkey *k) 
	bio_for_each_segment(bv, bio, iter) {

		void *d = kmap(bv.bv_page) + bv.bv_offset;



		csum = bch_crc64_update(csum, d, bv.bv_len);

		csum = crc64_be(csum, d, bv.bv_len);

		kunmap(bv.bv_page);

	}

drivers/md/bcache/util.h

+0 −8
Original line number Diff line number Diff line
@@ -548,14 +548,6 @@ static inline uint64_t bch_crc64(const void *p, size_t len) 
	return crc ^ 0xffffffffffffffffULL;

}



static inline uint64_t bch_crc64_update(uint64_t crc,

					const void *p,

					size_t len)

{

	crc = crc64_be(crc, p, len);

	return crc;

}



/*

 * A stepwise-linear pseudo-exponential.  This returns 1 << (x >>

 * frac_bits), with the less-significant bits filled in by linear