Unverified Commit 39f60c1c authored by Christian Brauner's avatar Christian Brauner Committed by Christian Brauner (Microsoft)
Browse files

fs: port xattr to mnt_idmap 



Convert to struct mnt_idmap.

Last cycle we merged the necessary infrastructure in
256c8aed ("fs: introduce dedicated idmap type for mounts").
This is just the conversion to struct mnt_idmap.

Currently we still pass around the plain namespace that was attached to a
mount. This is in general pretty convenient but it makes it easy to
conflate namespaces that are relevant on the filesystem with namespaces
that are relevent on the mount level. Especially for non-vfs developers
without detailed knowledge in this area this can be a potential source for
bugs.

Once the conversion to struct mnt_idmap is done all helpers down to the
really low-level helpers will take a struct mnt_idmap argument instead of
two namespace arguments. This way it becomes impossible to conflate the two
eliminating the possibility of any bugs. All of the vfs and all filesystems
only operate on struct mnt_idmap.

Acked-by: default avatarDave Chinner <dchinner@redhat.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarChristian Brauner (Microsoft) <brauner@kernel.org>
parent 4609e1f1

Documentation/filesystems/locking.rst

+1 −1
Original line number Diff line number Diff line
@@ -135,7 +135,7 @@ prototypes:: 
		   struct inode *inode, const char *name, void *buffer,

		   size_t size);

	int (*set)(const struct xattr_handler *handler,

                   struct user_namespace *mnt_userns,

                   struct mnt_idmap *idmap,

                   struct dentry *dentry, struct inode *inode, const char *name,

                   const void *buffer, size_t size, int flags);

fs/9p/xattr.c

+1 −1
Original line number Diff line number Diff line
@@ -150,7 +150,7 @@ static int v9fs_xattr_handler_get(const struct xattr_handler *handler, 
}



static int v9fs_xattr_handler_set(const struct xattr_handler *handler,

				  struct user_namespace *mnt_userns,

				  struct mnt_idmap *idmap,

				  struct dentry *dentry, struct inode *inode,

				  const char *name, const void *value,

				  size_t size, int flags)

fs/afs/xattr.c

+2 −2
Original line number Diff line number Diff line
@@ -97,7 +97,7 @@ static const struct afs_operation_ops afs_store_acl_operation = { 
 * Set a file's AFS3 ACL.

 */

static int afs_xattr_set_acl(const struct xattr_handler *handler,

			     struct user_namespace *mnt_userns,

			     struct mnt_idmap *idmap,

                             struct dentry *dentry,

                             struct inode *inode, const char *name,

                             const void *buffer, size_t size, int flags)
@@ -228,7 +228,7 @@ static const struct afs_operation_ops yfs_store_opaque_acl2_operation = { 
 * Set a file's YFS ACL.

 */

static int afs_xattr_set_yfs(const struct xattr_handler *handler,

			     struct user_namespace *mnt_userns,

			     struct mnt_idmap *idmap,

                             struct dentry *dentry,

                             struct inode *inode, const char *name,

                             const void *buffer, size_t size, int flags)

fs/attr.c

+2 −2
Original line number Diff line number Diff line
@@ -220,7 +220,7 @@ int setattr_prepare(struct mnt_idmap *idmap, struct dentry *dentry, 
	if (ia_valid & ATTR_KILL_PRIV) {

		int error;



		error = security_inode_killpriv(mnt_userns, dentry);

		error = security_inode_killpriv(idmap, dentry);

		if (error)

			return error;

	}
@@ -489,7 +489,7 @@ int notify_change(struct mnt_idmap *idmap, struct dentry *dentry, 


	if (!error) {

		fsnotify_change(dentry, ia_valid);

		ima_inode_post_setattr(mnt_userns, dentry);

		ima_inode_post_setattr(idmap, dentry);

		evm_inode_post_setattr(dentry, ia_valid);

	}

fs/btrfs/xattr.c

+2 −2
Original line number Diff line number Diff line
@@ -370,7 +370,7 @@ static int btrfs_xattr_handler_get(const struct xattr_handler *handler, 
}



static int btrfs_xattr_handler_set(const struct xattr_handler *handler,

				   struct user_namespace *mnt_userns,

				   struct mnt_idmap *idmap,

				   struct dentry *unused, struct inode *inode,

				   const char *name, const void *buffer,

				   size_t size, int flags)
@@ -383,7 +383,7 @@ static int btrfs_xattr_handler_set(const struct xattr_handler *handler, 
}



static int btrfs_xattr_handler_set_prop(const struct xattr_handler *handler,

					struct user_namespace *mnt_userns,

					struct mnt_idmap *idmap,

					struct dentry *unused, struct inode *inode,

					const char *name, const void *value,

					size_t size, int flags)