Commit 39e8cc6d authored by Alaa Hleihel's avatar Alaa Hleihel Committed by Saeed Mahameed
Browse files

net/mlx5e: Disable TLS device offload in kdump mode 



Under kdump environment we want to use the smallest possible amount
of resources, that includes setting SQ size to minimum.
However, when running on a device that supports TLS device offload,
then the SQ stop room becomes larger than with non-capable device and
requires increasing the SQ size.

Since TLS device offload is not necessary in kdump mode, disable it to
reduce the memory requirements for capable devices.

With this change, the needed SQ stop room size drops by 33.

Signed-off-by: default avatarAlaa Hleihel <alaa@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 040ee617

drivers/net/ethernet/mellanox/mlx5/core/en/params.c

+2 −2
Original line number Diff line number Diff line
@@ -614,7 +614,7 @@ static u8 mlx5e_build_icosq_log_wq_sz(struct mlx5e_params *params, 


static u8 mlx5e_build_async_icosq_log_wq_sz(struct mlx5_core_dev *mdev)

{

	if (mlx5_accel_is_ktls_rx(mdev))

	if (mlx5e_accel_is_ktls_rx(mdev))

		return MLX5E_PARAMS_DEFAULT_LOG_SQ_SIZE;



	return MLX5E_PARAMS_MINIMUM_LOG_SQ_SIZE;
@@ -643,7 +643,7 @@ static void mlx5e_build_async_icosq_param(struct mlx5_core_dev *mdev, 


	mlx5e_build_sq_param_common(mdev, param);

	param->stop_room = mlx5e_stop_room_for_wqe(1); /* for XSK NOP */

	param->is_tls = mlx5_accel_is_ktls_rx(mdev);

	param->is_tls = mlx5e_accel_is_ktls_rx(mdev);

	if (param->is_tls)

		param->stop_room += mlx5e_stop_room_for_wqe(1); /* for TLS RX resync NOP */

	MLX5_SET(sqc, sqc, reg_umr, MLX5_CAP_ETH(mdev, reg_umr_sq));

drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c

+7 −4
Original line number Diff line number Diff line
@@ -59,12 +59,15 @@ void mlx5e_ktls_build_netdev(struct mlx5e_priv *priv) 
	struct net_device *netdev = priv->netdev;

	struct mlx5_core_dev *mdev = priv->mdev;



	if (mlx5_accel_is_ktls_tx(mdev)) {

	if (!mlx5e_accel_is_ktls_tx(mdev) && !mlx5e_accel_is_ktls_rx(mdev))

		return;



	if (mlx5e_accel_is_ktls_tx(mdev)) {

		netdev->hw_features |= NETIF_F_HW_TLS_TX;

		netdev->features    |= NETIF_F_HW_TLS_TX;

	}



	if (mlx5_accel_is_ktls_rx(mdev))

	if (mlx5e_accel_is_ktls_rx(mdev))

		netdev->hw_features |= NETIF_F_HW_TLS_RX;



	netdev->tlsdev_ops = &mlx5e_ktls_ops;
@@ -89,7 +92,7 @@ int mlx5e_ktls_init_rx(struct mlx5e_priv *priv) 
{

	int err;



	if (!mlx5_accel_is_ktls_rx(priv->mdev))

	if (!mlx5e_accel_is_ktls_rx(priv->mdev))

		return 0;



	priv->tls->rx_wq = create_singlethread_workqueue("mlx5e_tls_rx");
@@ -109,7 +112,7 @@ int mlx5e_ktls_init_rx(struct mlx5e_priv *priv) 


void mlx5e_ktls_cleanup_rx(struct mlx5e_priv *priv)

{

	if (!mlx5_accel_is_ktls_rx(priv->mdev))

	if (!mlx5e_accel_is_ktls_rx(priv->mdev))

		return;



	if (priv->netdev->features & NETIF_F_HW_TLS_RX)

drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h

+24 −0
Original line number Diff line number Diff line
@@ -15,6 +15,25 @@ int mlx5e_ktls_set_feature_rx(struct net_device *netdev, bool enable); 
struct mlx5e_ktls_resync_resp *

mlx5e_ktls_rx_resync_create_resp_list(void);

void mlx5e_ktls_rx_resync_destroy_resp_list(struct mlx5e_ktls_resync_resp *resp_list);



static inline bool mlx5e_accel_is_ktls_tx(struct mlx5_core_dev *mdev)

{

	return !is_kdump_kernel() &&

		mlx5_accel_is_ktls_tx(mdev);

}



static inline bool mlx5e_accel_is_ktls_rx(struct mlx5_core_dev *mdev)

{

	return !is_kdump_kernel() &&

		mlx5_accel_is_ktls_rx(mdev);

}



static inline bool mlx5e_accel_is_ktls_device(struct mlx5_core_dev *mdev)

{

	return !is_kdump_kernel() &&

		mlx5_accel_is_ktls_device(mdev);

}



#else



static inline void mlx5e_ktls_build_netdev(struct mlx5e_priv *priv)
@@ -44,6 +63,11 @@ mlx5e_ktls_rx_resync_create_resp_list(void) 


static inline void

mlx5e_ktls_rx_resync_destroy_resp_list(struct mlx5e_ktls_resync_resp *resp_list) {}



static inline bool mlx5e_accel_is_ktls_tx(struct mlx5_core_dev *mdev) { return false; }

static inline bool mlx5e_accel_is_ktls_rx(struct mlx5_core_dev *mdev) { return false; }

static inline bool mlx5e_accel_is_ktls_device(struct mlx5_core_dev *mdev) { return false; }



#endif



#endif /* __MLX5E_TLS_H__ */

drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c

+4 −1
Original line number Diff line number Diff line
@@ -23,10 +23,13 @@ mlx5e_ktls_dumps_num_wqes(struct mlx5e_params *params, unsigned int nfrags, 
	return nfrags + DIV_ROUND_UP(sync_len, MLX5E_SW2HW_MTU(params, params->sw_mtu));

}



u16 mlx5e_ktls_get_stop_room(struct mlx5e_params *params)

u16 mlx5e_ktls_get_stop_room(struct mlx5_core_dev *mdev, struct mlx5e_params *params)

{

	u16 num_dumps, stop_room = 0;



	if (!mlx5e_accel_is_ktls_tx(mdev))

		return 0;



	num_dumps = mlx5e_ktls_dumps_num_wqes(params, MAX_SKB_FRAGS, TLS_MAX_PAYLOAD_SIZE);



	stop_room += mlx5e_stop_room_for_wqe(MLX5E_TLS_SET_STATIC_PARAMS_WQEBBS);

drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_txrx.h

+1 −1
Original line number Diff line number Diff line
@@ -14,7 +14,7 @@ struct mlx5e_accel_tx_tls_state { 
	u32 tls_tisn;

};



u16 mlx5e_ktls_get_stop_room(struct mlx5e_params *params);

u16 mlx5e_ktls_get_stop_room(struct mlx5_core_dev *mdev, struct mlx5e_params *params);



bool mlx5e_ktls_handle_tx_skb(struct tls_context *tls_ctx, struct mlx5e_txqsq *sq,

			      struct sk_buff *skb, int datalen,