Commit 39e222bf authored by Vladimir Oltean's avatar Vladimir Oltean Committed by Jakub Kicinski
Browse files

net: dsa: unregister cross-chip notifier after ds->ops->teardown 



To be symmetric with the error unwind path of dsa_switch_setup(), call
dsa_switch_unregister_notifier() after ds->ops->teardown.

The implication is that ds->ops->teardown cannot emit cross-chip
notifiers. For example, currently the dsa_tag_8021q_unregister() call
from sja1105_teardown() does not propagate to the entire tree due to
this reason. However I cannot find an actual issue caused by this,
observed using code inspection.

Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/20211012123735.2545742-1-vladimir.oltean@nxp.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 6312d528

net/dsa/dsa2.c

+2 −2
Original line number Diff line number Diff line
@@ -924,11 +924,11 @@ static void dsa_switch_teardown(struct dsa_switch *ds) 
		ds->slave_mii_bus = NULL;

	}



	dsa_switch_unregister_notifier(ds);



	if (ds->ops->teardown)

		ds->ops->teardown(ds);



	dsa_switch_unregister_notifier(ds);



	if (ds->devlink) {

		list_for_each_entry(dp, &ds->dst->ports, list)

			if (dp->ds == ds)