Commit 39e1674f authored by Christian Brauner's avatar Christian Brauner Committed by David Sterba
Browse files

btrfs: allow idmapped SUBVOL_SETFLAGS ioctl 



Setting flags on subvolumes or snapshots are core features of btrfs. The
SUBVOL_SETFLAGS ioctl is especially important as it allows to make
subvolumes and snapshots read-only or read-write. Allow setting flags on
btrfs subvolumes and snapshots on idmapped mounts. This is a fairly
straightforward operation since all the permission checking helpers are
already capable of handling idmapped mounts. So we just need to pass
down the mount's userns.

Reviewed-by: default avatarJosef Bacik <josef@toxicpanda.com>
Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent e4fed17a

fs/btrfs/ioctl.c

+1 −1
Original line number Diff line number Diff line
@@ -1988,7 +1988,7 @@ static noinline int btrfs_ioctl_subvol_setflags(struct file *file, 
	u64 flags;

	int ret = 0;



	if (!inode_owner_or_capable(&init_user_ns, inode))

	if (!inode_owner_or_capable(file_mnt_user_ns(file), inode))

		return -EPERM;



	ret = mnt_want_write_file(file);