Commit 39e1655c authored by Vitaly Lubart's avatar Vitaly Lubart Committed by Greg Kroah-Hartman
Browse files

mei: lower the log level for non-fatal failed messages 



Some non-fatal log messages should be logged at INFO log level
because failure to send/receive them is not breaking mei functionality
and may happen during legal firmware resets

Signed-off-by: default avatarVitaly Lubart <vitaly.lubart@intel.com>
Signed-off-by: default avatarTomas Winkler <tomas.winkler@intel.com>
Link: https://lore.kernel.org/r/20230207115520.846232-2-tomas.winkler@intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 784304ae

drivers/misc/mei/bus-fixup.c

+11 −11
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0

/*

 * Copyright (c) 2013-2022, Intel Corporation. All rights reserved.

 * Copyright (c) 2013-2023, Intel Corporation. All rights reserved.

 * Intel Management Engine Interface (Intel MEI) Linux driver

 */
@@ -151,7 +151,7 @@ static int mei_fwver(struct mei_cl_device *cldev) 
	ret = __mei_cl_send(cldev->cl, (u8 *)&req, sizeof(req), 0,

			    MEI_CL_IO_TX_BLOCKING);

	if (ret < 0) {

		dev_err(&cldev->dev, "Could not send ReqFWVersion cmd ret = %d\n", ret);

		dev_info(&cldev->dev, "Could not send ReqFWVersion cmd ret = %d\n", ret);

		return ret;

	}
@@ -163,7 +163,7 @@ static int mei_fwver(struct mei_cl_device *cldev) 
		 * Should be at least one version block,

		 * error out if nothing found

		 */

		dev_err(&cldev->dev, "Could not read FW version ret = %d\n", bytes_recv);

		dev_info(&cldev->dev, "Could not read FW version ret = %d\n", bytes_recv);

		return -EIO;

	}
@@ -220,14 +220,14 @@ static void mei_mkhi_fix(struct mei_cl_device *cldev) 
	if (cldev->bus->fw_f_fw_ver_supported) {

		ret = mei_fwver(cldev);

		if (ret < 0)

			dev_err(&cldev->dev, "FW version command failed %d\n",

			dev_info(&cldev->dev, "FW version command failed %d\n",

				 ret);

	}



	if (cldev->bus->hbm_f_os_supported) {

		ret = mei_osver(cldev);

		if (ret < 0)

			dev_err(&cldev->dev, "OS version command failed %d\n",

			dev_info(&cldev->dev, "OS version command failed %d\n",

				 ret);

	}

	mei_cldev_disable(cldev);
@@ -247,7 +247,7 @@ static void mei_gsc_mkhi_ver(struct mei_cl_device *cldev) 


	ret = mei_fwver(cldev);

	if (ret < 0)

		dev_err(&cldev->dev, "FW version command failed %d\n", ret);

		dev_info(&cldev->dev, "FW version command failed %d\n", ret);

	mei_cldev_disable(cldev);

}
@@ -278,7 +278,7 @@ static void mei_gsc_mkhi_fix_ver(struct mei_cl_device *cldev) 


	ret = mei_fwver(cldev);

	if (ret < 0)

		dev_err(&cldev->dev, "FW version command failed %d\n",

		dev_info(&cldev->dev, "FW version command failed %d\n",

			 ret);

out:

	mei_cldev_disable(cldev);