Commit 39cdb68c authored by Yangxi Xiang's avatar Yangxi Xiang Committed by Greg Kroah-Hartman
Browse files

vt: fix memory overlapping when deleting chars in the buffer 



A memory overlapping copy occurs when deleting a long line. This memory
overlapping copy can cause data corruption when scr_memcpyw is optimized
to memcpy because memcpy does not ensure its behavior if the destination
buffer overlaps with the source buffer. The line buffer is not always
broken, because the memcpy utilizes the hardware acceleration, whose
result is not deterministic.

Fix this problem by using replacing the scr_memcpyw with scr_memmovew.

Fixes: 81732c3b ("tty vt: Fix line garbage in virtual console on command line edition")
Cc: stable <stable@kernel.org>
Signed-off-by: default avatarYangxi Xiang <xyangxi5@gmail.com>
Link: https://lore.kernel.org/r/20220628093322.5688-1-xyangxi5@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4f532c1e

drivers/tty/vt/vt.c

+1 −1
Original line number Diff line number Diff line
@@ -855,7 +855,7 @@ static void delete_char(struct vc_data *vc, unsigned int nr) 
	unsigned short *p = (unsigned short *) vc->vc_pos;



	vc_uniscr_delete(vc, nr);

	scr_memcpyw(p, p + nr, (vc->vc_cols - vc->state.x - nr) * 2);

	scr_memmovew(p, p + nr, (vc->vc_cols - vc->state.x - nr) * 2);

	scr_memsetw(p + vc->vc_cols - vc->state.x - nr, vc->vc_video_erase_char,

			nr * 2);

	vc->vc_need_wrap = 0;