Commit 39cad887 authored by George G. Davis's avatar George G. Davis Committed by Linus Torvalds
Browse files

selftests/vm/transhuge-stress: fix ram size thinko 

When executing transhuge-stress with an argument to specify the virtual
memory size for testing, the ram size is reported as 0, e.g.

  transhuge-stress 384
  thp-mmap: allocate 192 transhuge pages, using 384 MiB virtual memory and 0 MiB of ram
  thp-mmap: 0.184 s/loop, 0.957 ms/page,   2090.265 MiB/s  192 succeed,    0 failed

This appears to be due to a thinko in commit 0085d61f
("selftests/vm/transhuge-stress: stress test for memory compaction"),
where, at a guess, the intent was to base "xyz MiB of ram" on `ram`
size.

Here are results after using `ram` size:

  thp-mmap: allocate 192 transhuge pages, using 384 MiB virtual memory and 14 MiB of ram

Link: https://lkml.kernel.org/r/20210825135843.29052-1-george_davis@mentor.com


Fixes: 0085d61f ("selftests/vm/transhuge-stress: stress test for memory compaction")
Signed-off-by: default avatarGeorge G. Davis <davis.george@siemens.com>
Cc: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: Eugeniu Rosca <erosca@de.adit-jv.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 20f9ba4f

tools/testing/selftests/vm/transhuge-stress.c

+1 −1
Original line number Diff line number Diff line
@@ -79,7 +79,7 @@ int main(int argc, char **argv) 


	warnx("allocate %zd transhuge pages, using %zd MiB virtual memory"

	      " and %zd MiB of ram", len >> HPAGE_SHIFT, len >> 20,

	      len >> (20 + HPAGE_SHIFT - PAGE_SHIFT - 1));

	      ram >> (20 + HPAGE_SHIFT - PAGE_SHIFT - 1));



	pagemap_fd = open("/proc/self/pagemap", O_RDONLY);

	if (pagemap_fd < 0)