Commit 39a1a86b authored Apr 12, 2022 by James Smart Committed by Martin K. Petersen Apr 18, 2022

scsi: lpfc: Move MI module parameter check to handle dynamic disable

lpfc_refresh_params() can be called for an async event handler. This could
potentially override the value initialized by lpfc_cmf_setup().

Move module parameter check to lpfc_refresh_params().

Link: https://lore.kernel.org/r/20220412222008.126521-14-jsmart2021@gmail.com


Co-developed-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent d531d987

drivers/scsi/lpfc/lpfc_init.c

+7 −1

Original line number	Diff line number	Diff line
		@@ -686,8 +686,14 @@ lpfc_sli4_refresh_params(struct lpfc_hba *phba)
		return rc;
		}
		mbx_sli4_parameters = &mqe->un.get_sli4_parameters.sli4_parameters;

		/* Are we forcing MI off via module parameter? */
		if (phba->cfg_enable_mi)
		phba->sli4_hba.pc_sli4_params.mi_ver =
		bf_get(cfg_mi_ver, mbx_sli4_parameters);
		else
		phba->sli4_hba.pc_sli4_params.mi_ver = 0;

		phba->sli4_hba.pc_sli4_params.cmf =
		bf_get(cfg_cmf, mbx_sli4_parameters);
		phba->sli4_hba.pc_sli4_params.pls =

drivers/scsi/lpfc/lpfc_sli.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -7994,10 +7994,6 @@ lpfc_cmf_setup(struct lpfc_hba *phba)

		sli4_params = &phba->sli4_hba.pc_sli4_params;

		/* Are we forcing MI off via module parameter? */
		if (!phba->cfg_enable_mi)
		sli4_params->mi_ver = 0;

		/* Always try to enable MI feature if we can */
		if (sli4_params->mi_ver) {
		lpfc_set_features(phba, mboxq, LPFC_SET_ENABLE_MI);