Commit 3999434b authored by Chaitanya Kulkarni's avatar Chaitanya Kulkarni Committed by Christoph Hellwig
Browse files

nvmet: remove extra variable in id-ns handler 



In nvmet_execute_identify_ns() local variable ctrl is accessed only in
one place, remove that and directly use it from nvmet_req->sq->ctrl.

Signed-off-by: default avatarChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 3a1f7c79

drivers/nvme/target/admin-cmd.c

+1 −2
Original line number Diff line number Diff line
@@ -462,7 +462,6 @@ static void nvmet_execute_identify_ctrl(struct nvmet_req *req) 


static void nvmet_execute_identify_ns(struct nvmet_req *req)

{

	struct nvmet_ctrl *ctrl = req->sq->ctrl;

	struct nvme_id_ns *id;

	u16 status;
@@ -523,7 +522,7 @@ static void nvmet_execute_identify_ns(struct nvmet_req *req) 


	id->lbaf[0].ds = req->ns->blksize_shift;



	if (ctrl->pi_support && nvmet_ns_has_pi(req->ns)) {

	if (req->sq->ctrl->pi_support && nvmet_ns_has_pi(req->ns)) {

		id->dpc = NVME_NS_DPC_PI_FIRST | NVME_NS_DPC_PI_LAST |

			  NVME_NS_DPC_PI_TYPE1 | NVME_NS_DPC_PI_TYPE2 |

			  NVME_NS_DPC_PI_TYPE3;