Commit 39793ec5 authored Sep 07, 2024 by Li Lingfeng

nfs: fix memory leak in error path of nfs4_do_reclaim

hulk inclusion
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IAPAZ3



--------------------------------

Commit c77e2283 ("NFSv4: Fix a potential sleep while atomic in
nfs4_do_reclaim()") separate out the freeing of the state owners from
nfs4_purge_state_owners() and finish it outside the rcu lock.
However, the error path is omitted. As a result, the state owners in
"freeme" will not be released.
Fix it by adding freeing in the error path.

Fixes: c77e2283 ("NFSv4: Fix a potential sleep while atomic in nfs4_do_reclaim()")
Signed-off-by: Li Lingfeng <lilingfeng3@huawei.com>

parent 10e0ea77

fs/nfs/nfs4state.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1957,6 +1957,7 @@ static int nfs4_do_reclaim(struct nfs_client *clp, const struct nfs4_state_recov
		set_bit(ops->owner_flag_bit, &sp->so_flags);
		nfs4_put_state_owner(sp);
		status = nfs4_recovery_handle_error(clp, status);
		nfs4_free_state_owners(&freeme);
		return (status != 0) ? status : -EAGAIN;
		}