Commit 3976e974 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Lee Jones
Browse files

video: backlight: ili9320: Make ili9320_remove() return void 



Up to now ili9320_remove() returns zero unconditionally. Make it return
void instead which makes it easier to see in the callers that there is
no error to handle.

Also the return value of spi remove callbacks is ignored anyway.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarDaniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20211019120927.3822792-1-u.kleine-koenig@pengutronix.de
parent 563edf85

drivers/video/backlight/ili9320.c

+1 −2
Original line number Diff line number Diff line
@@ -251,10 +251,9 @@ int ili9320_probe_spi(struct spi_device *spi, 
}

EXPORT_SYMBOL_GPL(ili9320_probe_spi);



int ili9320_remove(struct ili9320 *ili)

void ili9320_remove(struct ili9320 *ili)

{

	ili9320_power(ili, FB_BLANK_POWERDOWN);

	return 0;

}

EXPORT_SYMBOL_GPL(ili9320_remove);

drivers/video/backlight/ili9320.h

+1 −1
Original line number Diff line number Diff line
@@ -68,7 +68,7 @@ extern int ili9320_write_regs(struct ili9320 *ili, 
extern int ili9320_probe_spi(struct spi_device *spi,

			     struct ili9320_client *cli);



extern int ili9320_remove(struct ili9320 *lcd);

extern void ili9320_remove(struct ili9320 *lcd);

extern void ili9320_shutdown(struct ili9320 *lcd);



/* PM */

drivers/video/backlight/vgg2432a4.c

+3 −1
Original line number Diff line number Diff line
@@ -235,7 +235,9 @@ static int vgg2432a4_probe(struct spi_device *spi) 


static int vgg2432a4_remove(struct spi_device *spi)

{

	return ili9320_remove(spi_get_drvdata(spi));

	ili9320_remove(spi_get_drvdata(spi));



	return 0;

}



static void vgg2432a4_shutdown(struct spi_device *spi)