Commit 397605c2 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Ulf Hansson
Browse files

mmc: dw_mmc: rockchip: Obviously always return success in remove callback 



dw_mci_pltfm_remove() returns 0 unconditionally and returning an error
in a platform remove callback isn't very sensible. (The only effect of
the latter is that the device core emits a generic warning and then
removes the device anyhow.)

So return 0 unconditionally to make it obvious there is no error
forwarded to the upper layers.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20220610211257.102071-3-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 50699358

drivers/mmc/host/dw_mmc-rockchip.c

+3 −1
Original line number Diff line number Diff line
@@ -377,7 +377,9 @@ static int dw_mci_rockchip_remove(struct platform_device *pdev) 
	pm_runtime_disable(&pdev->dev);

	pm_runtime_put_noidle(&pdev->dev);



	return dw_mci_pltfm_remove(pdev);

	dw_mci_pltfm_remove(pdev);



	return 0;

}



static const struct dev_pm_ops dw_mci_rockchip_dev_pm_ops = {