Commit 3969b1a6 authored by John Hubbard's avatar John Hubbard Committed by Linus Torvalds
Browse files

mm: delete unused get_kernel_page() 

get_kernel_page() was added in 2012 by [1].  It was used for a while for
NFS, but then in 2014, a refactoring [2] removed all callers, and it has
apparently not been used since.

Remove get_kernel_page() because it has no callers.

[1] commit 18022c5d ("mm: add get_kernel_page[s] for pinning of
    kernel addresses for I/O")
[2] commit 91f79c43 ("new helper: iov_iter_get_pages_alloc()")

Link: https://lkml.kernel.org/r/20210729221847.1165665-1-jhubbard@nvidia.com


Signed-off-by: default avatarJohn Hubbard <jhubbard@nvidia.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDavid Hildenbrand <david@redhat.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Rik van Riel <riel@redhat.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Eric B Munson <emunson@mgebm.net>
Cc: Eric Paris <eparis@redhat.com>
Cc: James Morris <jmorris@namei.org>
Cc: Mike Christie <michaelc@cs.wisc.edu>
Cc: Neil Brown <neilb@suse.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Xiaotian Feng <dfeng@redhat.com>
Cc: Mark Salter <msalter@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 51cc3a66

include/linux/mm.h

+0 −1
Original line number Diff line number Diff line
@@ -1839,7 +1839,6 @@ int __account_locked_vm(struct mm_struct *mm, unsigned long pages, bool inc, 
struct kvec;

int get_kernel_pages(const struct kvec *iov, int nr_pages, int write,

			struct page **pages);

int get_kernel_page(unsigned long start, int write, struct page **pages);

struct page *get_dump_page(unsigned long addr);



extern int try_to_release_page(struct page * page, gfp_t gfp_mask);

mm/swap.c

+0 −22
Original line number Diff line number Diff line
@@ -179,28 +179,6 @@ int get_kernel_pages(const struct kvec *kiov, int nr_segs, int write, 
}

EXPORT_SYMBOL_GPL(get_kernel_pages);



/*

 * get_kernel_page() - pin a kernel page in memory

 * @start:	starting kernel address

 * @write:	pinning for read/write, currently ignored

 * @pages:	array that receives pointer to the page pinned.

 *		Must be at least nr_segs long.

 *

 * Returns 1 if page is pinned. If the page was not pinned, returns

 * -errno. The page returned must be released with a put_page() call

 * when it is finished with.

 */

int get_kernel_page(unsigned long start, int write, struct page **pages)

{

	const struct kvec kiov = {

		.iov_base = (void *)start,

		.iov_len = PAGE_SIZE

	};



	return get_kernel_pages(&kiov, 1, write, pages);

}

EXPORT_SYMBOL_GPL(get_kernel_page);



static void pagevec_lru_move_fn(struct pagevec *pvec,

	void (*move_fn)(struct page *page, struct lruvec *lruvec))

{