Commit 39200687 authored by Ewan D. Milne's avatar Ewan D. Milne Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Fix mailbox direction flags in qla2xxx_get_adapter_id() 

The SCM changes set the flags in mcp->out_mb instead of mcp->in_mb so the
data was not actually being read into the mcp->mb[] array from the adapter.

Link: https://lore.kernel.org/r/20211108183012.13895-1-emilne@redhat.com


Fixes: 9f2475fe ("scsi: qla2xxx: SAN congestion management implementation")
Cc: stable@vger.kernel.org
Reviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
Reviewed-by: default avatarArun Easi <aeasi@marvell.com>
Signed-off-by: default avatarEwan D. Milne <emilne@redhat.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 5cb37a26

drivers/scsi/qla2xxx/qla_mbx.c

+2 −4
Original line number Diff line number Diff line
@@ -1695,10 +1695,8 @@ qla2x00_get_adapter_id(scsi_qla_host_t *vha, uint16_t *id, uint8_t *al_pa, 
		mcp->in_mb |= MBX_13|MBX_12|MBX_11|MBX_10;

	if (IS_FWI2_CAPABLE(vha->hw))

		mcp->in_mb |= MBX_19|MBX_18|MBX_17|MBX_16;

	if (IS_QLA27XX(vha->hw) || IS_QLA28XX(vha->hw)) {

		mcp->in_mb |= MBX_15;

		mcp->out_mb |= MBX_7|MBX_21|MBX_22|MBX_23;

	}

	if (IS_QLA27XX(vha->hw) || IS_QLA28XX(vha->hw))

		mcp->in_mb |= MBX_15|MBX_21|MBX_22|MBX_23;



	mcp->tov = MBX_TOV_SECONDS;

	mcp->flags = 0;