Commit 3907e683 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev/hecubafb: Use struct fb_info.screen_buffer 



Use info->screen_buffer when reading and writing framebuffers in
system memory. It's the correct pointer for this address space.

The struct fb_info has a union to store the framebuffer memory. This can
either be info->screen_base if the framebuffer is stored in I/O memory,
or info->screen_buffer if the framebuffer is stored in system memory.

As the driver operates on the latter address space, it is wrong to use
.screen_base and .screen_buffer must be used instead. This also gets
rid of casting needed due to not using the correct data type.

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230428122452.4856-8-tzimmermann@suse.de
parent ada45eda

drivers/video/fbdev/hecubafb.c

+4 −4
Original line number Diff line number Diff line
@@ -102,7 +102,7 @@ static void apollo_send_command(struct hecubafb_par *par, unsigned char data) 
static void hecubafb_dpy_update(struct hecubafb_par *par)

{

	int i;

	unsigned char *buf = (unsigned char __force *)par->info->screen_base;

	unsigned char *buf = par->info->screen_buffer;



	apollo_send_command(par, APOLLO_START_NEW_IMG);
@@ -183,7 +183,7 @@ static ssize_t hecubafb_write(struct fb_info *info, const char __user *buf, 
		count = total_size - p;

	}



	dst = (void __force *) (info->screen_base + p);

	dst = info->screen_buffer + p;



	if (copy_from_user(dst, buf, count))

		err = -EFAULT;
@@ -239,7 +239,7 @@ static int hecubafb_probe(struct platform_device *dev) 
	if (!info)

		goto err_fballoc;



	info->screen_base = (char __force __iomem *)videomemory;

	info->screen_buffer = videomemory;

	info->fbops = &hecubafb_ops;



	info->var = hecubafb_var;
@@ -287,7 +287,7 @@ static int hecubafb_remove(struct platform_device *dev) 
		struct hecubafb_par *par = info->par;

		fb_deferred_io_cleanup(info);

		unregister_framebuffer(info);

		vfree((void __force *)info->screen_base);

		vfree(info->screen_buffer);

		if (par->board->remove)

			par->board->remove(par);

		module_put(par->board->owner);