Commit 38dfa56b authored by Saravana Kannan's avatar Saravana Kannan Committed by Greg Kroah-Hartman
Browse files

gpiolib: Clear the gpio_device's fwnode initialized flag before adding 



Registering an irqdomain sets the flag for the fwnode. But having the
flag set when a device is added is interpreted by fw_devlink to mean the
device has already been initialized and will never probe. This prevents
fw_devlink from creating device links with the gpio_device as a
supplier. So, clear the flag before adding the device.

Signed-off-by: default avatarSaravana Kannan <saravanak@google.com>
Acked-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
Tested-by: default avatarColin Foster <colin.foster@in-advantage.com>
Tested-by: default avatarSudeep Holla <sudeep.holla@arm.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: default avatarDouglas Anderson <dianders@chromium.org>
Tested-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Luca Weiss <luca.weiss@fairphone.com> # qcom/sm7225-fairphone-fp4
Link: https://lore.kernel.org/r/20230207014207.1678715-5-saravanak@google.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8640166f

drivers/gpio/gpiolib.c

+7 −0
Original line number Diff line number Diff line
@@ -578,6 +578,13 @@ static int gpiochip_setup_dev(struct gpio_device *gdev) 
{

	int ret;



	/*

	 * If fwnode doesn't belong to another device, it's safe to clear its

	 * initialized flag.

	 */

	if (gdev->dev.fwnode && !gdev->dev.fwnode->dev)

		fwnode_dev_initialized(gdev->dev.fwnode, false);



	ret = gcdev_register(gdev, gpio_devt);

	if (ret)

		return ret;