Commit 38d9f06c authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (tmp401) Drop support for TMP461 



TMP461 is almost identical to TMP451, which is already supported by the
lm90 driver. At the same time, unlike other sensors from the TMP401
compatible series, it only supports 8-bit temperature read operations,
and it supports negative temperatures when configured for its default
temperature range, and it supports a temperature offset register.
Supporting this chip in the tmp401 driver adds unnecessary complexity.
Remove its support from this driver and support the chip with the lm90
driver instead.

Fixes: 24333ac2 ("hwmon: (tmp401) use smb word operations instead of 2 smb byte operations")
Reported-by: default avatarDavid T. Wilson <david.wilson@nasa.gov>
Cc: David T. Wilson <david.wilson@nasa.gov>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent f8344f76

Documentation/hwmon/tmp401.rst

+1 −14
Original line number Diff line number Diff line
@@ -43,12 +43,6 @@ Supported chips: 


    Datasheet: http://focus.ti.com/docs/prod/folders/print/tmp435.html



  * Texas Instruments TMP461



    Prefix: 'tmp461'



    Datasheet: https://www.ti.com/product/tmp461







Authors:
@@ -60,7 +54,7 @@ Description 
-----------



This driver implements support for Texas Instruments TMP401, TMP411,

TMP431, TMP432, TMP435, and TMP461 chips. These chips implement one or two

TMP431, TMP432, and TMP435 chips. These chips implement one or two

remote and one local temperature sensors. Temperature is measured in degrees

Celsius. Resolution of the remote sensor is 0.0625 degree. Local

sensor resolution can be set to 0.5, 0.25, 0.125 or 0.0625 degree (not
@@ -84,10 +78,3 @@ some additional features. 


TMP432 is compatible with TMP401 and TMP431. It supports two external

temperature sensors.
 


TMP461 is compatible with TMP401. It supports offset correction

that is applied to the remote sensor.



* Sensor offset values are temperature values



  Exported via sysfs attribute tempX_offset

drivers/hwmon/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -1941,7 +1941,7 @@ config SENSORS_TMP401 
	depends on I2C

	help

	  If you say yes here you get support for Texas Instruments TMP401,

	  TMP411, TMP431, TMP432, TMP435, and TMP461 temperature sensor chips.

	  TMP411, TMP431, TMP432, and TMP435 temperature sensor chips.



	  This driver can also be built as a module. If so, the module

	  will be called tmp401.

drivers/hwmon/tmp401.c

+2 −23
Original line number Diff line number Diff line
@@ -34,7 +34,7 @@ 
static const unsigned short normal_i2c[] = { 0x48, 0x49, 0x4a, 0x4c, 0x4d,

	0x4e, 0x4f, I2C_CLIENT_END };



enum chips { tmp401, tmp411, tmp431, tmp432, tmp435, tmp461 };

enum chips { tmp401, tmp411, tmp431, tmp432, tmp435 };



/*

 * The TMP401 registers, note some registers have different addresses for
@@ -56,7 +56,6 @@ static const u8 TMP401_TEMP_MSB_READ[7][2] = { 
	{ 0x20, 0x19 },	/* therm (crit) limit */

	{ 0x30, 0x34 },	/* lowest */

	{ 0x32, 0x36 },	/* highest */

	{ 0, 0x11 },	/* offset */

};



static const u8 TMP401_TEMP_MSB_WRITE[7][2] = {
@@ -66,7 +65,6 @@ static const u8 TMP401_TEMP_MSB_WRITE[7][2] = { 
	{ 0x20, 0x19 },	/* therm (crit) limit */

	{ 0x30, 0x34 },	/* lowest */

	{ 0x32, 0x36 },	/* highest */

	{ 0, 0x11 },	/* offset */

};



static const u8 TMP432_TEMP_MSB_READ[4][3] = {
@@ -123,7 +121,6 @@ static const struct i2c_device_id tmp401_id[] = { 
	{ "tmp431", tmp431 },

	{ "tmp432", tmp432 },

	{ "tmp435", tmp435 },

	{ "tmp461", tmp461 },

	{ }

};

MODULE_DEVICE_TABLE(i2c, tmp401_id);
@@ -570,21 +567,6 @@ static const struct attribute_group tmp432_group = { 
	.attrs = tmp432_attributes,

};



/*

 * Additional features of the TMP461 chip.

 * The TMP461 temperature offset for the remote channel.

 */

static SENSOR_DEVICE_ATTR_2_RW(temp2_offset, temp, 6, 1);



static struct attribute *tmp461_attributes[] = {

	&sensor_dev_attr_temp2_offset.dev_attr.attr,

	NULL

};



static const struct attribute_group tmp461_group = {

	.attrs = tmp461_attributes,

};



/*

 * Begin non sysfs callback code (aka Real code)

 */
@@ -686,7 +668,7 @@ static int tmp401_detect(struct i2c_client *client, 
static int tmp401_probe(struct i2c_client *client)

{

	static const char * const names[] = {

		"TMP401", "TMP411", "TMP431", "TMP432", "TMP435", "TMP461"

		"TMP401", "TMP411", "TMP431", "TMP432", "TMP435"

	};

	struct device *dev = &client->dev;

	struct device *hwmon_dev;
@@ -717,9 +699,6 @@ static int tmp401_probe(struct i2c_client *client) 
	if (data->kind == tmp432)

		data->groups[groups++] = &tmp432_group;



	if (data->kind == tmp461)

		data->groups[groups++] = &tmp461_group;



	hwmon_dev = devm_hwmon_device_register_with_groups(dev, client->name,

							   data, data->groups);

	if (IS_ERR(hwmon_dev))