Commit 38c5b0dd authored by Armin Wolf's avatar Armin Wolf Committed by Guenter Roeck
Browse files

hwmon: (dell-smm) Use strscpy_pad() 



Using strscpy_pad() allows for fewer memory accesses
since memset() will not unconditionally zero-out
the whole buffer.

Signed-off-by: default avatarArmin Wolf <W_Armin@gmx.de>
Acked-by: default avatarPali Rohár <pali@kernel.org>
Link: https://lore.kernel.org/r/20211021190531.17379-3-W_Armin@gmx.de


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 6105870f

drivers/hwmon/dell-smm-hwmon.c

+2 −2
Original line number Diff line number Diff line
@@ -25,6 +25,7 @@ 
#include <linux/platform_device.h>

#include <linux/proc_fs.h>

#include <linux/seq_file.h>

#include <linux/string.h>

#include <linux/smp.h>

#include <linux/types.h>

#include <linux/uaccess.h>
@@ -472,8 +473,7 @@ i8k_ioctl_unlocked(struct file *fp, struct dell_smm_data *data, unsigned int cmd 
		if (restricted && !capable(CAP_SYS_ADMIN))

			return -EPERM;



		memset(buff, 0, sizeof(buff));

		strscpy(buff, data->bios_machineid, sizeof(buff));

		strscpy_pad(buff, data->bios_machineid, sizeof(buff));

		break;



	case I8K_FN_STATUS: