Commit 38c58301 authored by Imre Deak's avatar Imre Deak Committed by Jani Nikula
Browse files

drm/i915/tc: Fix the ICL PHY ownership check in TC-cold state 



The commit renaming icl_tc_phy_is_in_safe_mode() to
icl_tc_phy_take_ownership() didn't flip the function's return value
accordingly, fix this up.

This didn't cause an actual problem besides state check errors, since
the function is only used during HW readout.

Cc: José Roberto de Souza <jose.souza@intel.com>
Fixes: f53979d6 ("drm/i915/display/tc: Rename safe_mode functions ownership")
Reviewed-by: default avatarJosé Roberto de Souza <jose.souza@intel.com>
Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: default avatarImre Deak <imre.deak@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230316131724.359612-4-imre.deak@intel.com


(cherry picked from commit f2c7959d)
Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
parent a2b6e99d

drivers/gpu/drm/i915/display/intel_tc.c

+2 −2
Original line number Diff line number Diff line
@@ -418,9 +418,9 @@ static bool icl_tc_phy_is_owned(struct intel_digital_port *dig_port) 
	val = intel_de_read(i915, PORT_TX_DFLEXDPCSSS(dig_port->tc_phy_fia));

	if (val == 0xffffffff) {

		drm_dbg_kms(&i915->drm,

			    "Port %s: PHY in TCCOLD, assume safe mode\n",

			    "Port %s: PHY in TCCOLD, assume not owned\n",

			    dig_port->tc_port_name);

		return true;

		return false;

	}



	return val & DP_PHY_MODE_STATUS_NOT_SAFE(dig_port->tc_phy_fia_idx);