Commit 386e5e6e authored by Sagi Grimberg's avatar Sagi Grimberg Committed by Jens Axboe
Browse files

nvme-tcp: use bh_lock in data_ready 



data_ready may be invoked from send context or from
softirq, so need bh locking for that.

Fixes: 3f2304f8 ("nvme-tcp: add NVMe over TCP host driver")
Signed-off-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 2a5bcfdd

drivers/nvme/host/tcp.c

+2 −2
Original line number Diff line number Diff line
@@ -794,11 +794,11 @@ static void nvme_tcp_data_ready(struct sock *sk) 
{

	struct nvme_tcp_queue *queue;



	read_lock(&sk->sk_callback_lock);

	read_lock_bh(&sk->sk_callback_lock);

	queue = sk->sk_user_data;

	if (likely(queue && queue->rd_enabled))

		queue_work_on(queue->io_cpu, nvme_tcp_wq, &queue->io_work);

	read_unlock(&sk->sk_callback_lock);

	read_unlock_bh(&sk->sk_callback_lock);

}



static void nvme_tcp_write_space(struct sock *sk)