Commit 386228c6 authored by Christian Marangi's avatar Christian Marangi Committed by Jakub Kicinski
Browse files

net: dsa: qca8k: reset cpu port on MTU change 



It was discovered that the Documentation lacks of a fundamental detail
on how to correctly change the MAX_FRAME_SIZE of the switch.

In fact if the MAX_FRAME_SIZE is changed while the cpu port is on, the
switch panics and cease to send any packet. This cause the mgmt ethernet
system to not receive any packet (the slow fallback still works) and
makes the device not reachable. To recover from this a switch reset is
required.

To correctly handle this, turn off the cpu ports before changing the
MAX_FRAME_SIZE and turn on again after the value is applied.

Fixes: f58d2598 ("net: dsa: qca8k: implement the port MTU callbacks")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarChristian Marangi <ansuelsmth@gmail.com>
Link: https://lore.kernel.org/r/20220621151122.10220-1-ansuelsmth@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 13f28c2c

drivers/net/dsa/qca8k.c

+21 −1
Original line number Diff line number Diff line
@@ -2334,6 +2334,7 @@ static int 
qca8k_port_change_mtu(struct dsa_switch *ds, int port, int new_mtu)

{

	struct qca8k_priv *priv = ds->priv;

	int ret;



	/* We have only have a general MTU setting.

	 * DSA always set the CPU port's MTU to the largest MTU of the slave
@@ -2344,8 +2345,27 @@ qca8k_port_change_mtu(struct dsa_switch *ds, int port, int new_mtu) 
	if (!dsa_is_cpu_port(ds, port))

		return 0;



	/* To change the MAX_FRAME_SIZE the cpu ports must be off or

	 * the switch panics.

	 * Turn off both cpu ports before applying the new value to prevent

	 * this.

	 */

	if (priv->port_enabled_map & BIT(0))

		qca8k_port_set_status(priv, 0, 0);



	if (priv->port_enabled_map & BIT(6))

		qca8k_port_set_status(priv, 6, 0);



	/* Include L2 header / FCS length */

	return qca8k_write(priv, QCA8K_MAX_FRAME_SIZE, new_mtu + ETH_HLEN + ETH_FCS_LEN);

	ret = qca8k_write(priv, QCA8K_MAX_FRAME_SIZE, new_mtu + ETH_HLEN + ETH_FCS_LEN);



	if (priv->port_enabled_map & BIT(0))

		qca8k_port_set_status(priv, 0, 1);



	if (priv->port_enabled_map & BIT(6))

		qca8k_port_set_status(priv, 6, 1);



	return ret;

}



static int