Commit 3849e092 authored by Sean Christopherson's avatar Sean Christopherson Committed by Paolo Bonzini
Browse files

KVM: x86/mmu: Drop redundant trace_kvm_mmu_set_spte() in the TDP MMU 



Remove TDP MMU's call to trace_kvm_mmu_set_spte() that is done for both
shadow-present SPTEs and MMIO SPTEs.  It's fully redundant for the
former, and unnecessary for the latter.  This aligns TDP MMU tracing
behavior with that of the legacy MMU.

Fixes: 33dd3574 ("kvm: x86/mmu: Add existing trace points to TDP MMU")
Cc: Ben Gardon <bgardon@google.com>
Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
Message-Id: <20210225204749.1512652-9-seanjc@google.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent a54aa15c

arch/x86/kvm/mmu/tdp_mmu.c

+2 −3
Original line number Original line Diff line number Diff line
@@ -771,12 +771,11 @@ static int tdp_mmu_map_handle_target_level(struct kvm_vcpu *vcpu, int write, 
		trace_mark_mmio_spte(rcu_dereference(iter->sptep), iter->gfn,

		trace_mark_mmio_spte(rcu_dereference(iter->sptep), iter->gfn,

				     new_spte);

				     new_spte);

		ret = RET_PF_EMULATE;

		ret = RET_PF_EMULATE;

	} else

	} else {

		trace_kvm_mmu_set_spte(iter->level, iter->gfn,

		trace_kvm_mmu_set_spte(iter->level, iter->gfn,

				       rcu_dereference(iter->sptep));

				       rcu_dereference(iter->sptep));

	}





	trace_kvm_mmu_set_spte(iter->level, iter->gfn,

			       rcu_dereference(iter->sptep));

	if (!prefault)

	if (!prefault)

		vcpu->stat.pf_fixed++;

		vcpu->stat.pf_fixed++;