Commit 383ce25d authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Herbert Xu
Browse files

crypto: ccree - Remove a useless dma_supported() call 

There is no point in calling dma_supported() before calling
dma_set_coherent_mask(). This function already calls dma_supported() and
returns an error (-EIO) if it fails.

So remove the superfluous dma_supported() call.

Moreover, setting a larger DMA mask will never fail when setting a smaller
one will succeed, so the whole "while" loop can be removed as well. (see
[1])

While at it, fix the name of the function reported in a dev_err().

[1]: https://lore.kernel.org/all/YteQ6Vx2C03UtCkG@infradead.org/



Suggested-by: default avatarChristoph Hellwig <hch@infradead.org>
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: default avatarGilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 96ec8dfd

drivers/crypto/ccree/cc_driver.c

+3 −10
Original line number Diff line number Diff line
@@ -372,17 +372,10 @@ static int init_cc_resources(struct platform_device *plat_dev) 
		dev->dma_mask = &dev->coherent_dma_mask;



	dma_mask = DMA_BIT_MASK(DMA_BIT_MASK_LEN);

	while (dma_mask > 0x7fffffffUL) {

		if (dma_supported(dev, dma_mask)) {

	rc = dma_set_coherent_mask(dev, dma_mask);

			if (!rc)

				break;

		}

		dma_mask >>= 1;

	}



	if (rc) {

		dev_err(dev, "Failed in dma_set_mask, mask=%llx\n", dma_mask);

		dev_err(dev, "Failed in dma_set_coherent_mask, mask=%llx\n",

			dma_mask);

		return rc;

	}