Commit 382d917b authored by Zheng Bin's avatar Zheng Bin Committed by David S. Miller
Browse files

net: hinic: add missing destroy_workqueue in hinic_pf_to_mgmt_init 



hinic_pf_to_mgmt_init misses destroy_workqueue in error path,
this patch fixes that.

Fixes: 6dbb8901 ("hinic: fix sending mailbox timeout in aeq event work")
Signed-off-by: default avatarZheng Bin <zhengbin13@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6ee1d84b

drivers/net/ethernet/huawei/hinic/hinic_hw_mgmt.c

+2 −0
Original line number Diff line number Diff line
@@ -643,6 +643,7 @@ int hinic_pf_to_mgmt_init(struct hinic_pf_to_mgmt *pf_to_mgmt, 
	err = alloc_msg_buf(pf_to_mgmt);

	if (err) {

		dev_err(&pdev->dev, "Failed to allocate msg buffers\n");

		destroy_workqueue(pf_to_mgmt->workq);

		hinic_health_reporters_destroy(hwdev->devlink_dev);

		return err;

	}
@@ -650,6 +651,7 @@ int hinic_pf_to_mgmt_init(struct hinic_pf_to_mgmt *pf_to_mgmt, 
	err = hinic_api_cmd_init(pf_to_mgmt->cmd_chain, hwif);

	if (err) {

		dev_err(&pdev->dev, "Failed to initialize cmd chains\n");

		destroy_workqueue(pf_to_mgmt->workq);

		hinic_health_reporters_destroy(hwdev->devlink_dev);

		return err;

	}