Commit 382be668 authored by Dan Carpenter's avatar Dan Carpenter Committed by James Bottomley
Browse files

[SCSI] hpsa: fix bad comparison 



'!' has higher precedence than '&'.  CFGTBL_ChangeReq is 0x1 so the
original code is equivelent to if (!doorbell_value) {...

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Acked-by: default avatarStephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent ba95e2ac

drivers/scsi/hpsa.c

+1 −1
Original line number Diff line number Diff line
@@ -3614,7 +3614,7 @@ static void __devinit hpsa_wait_for_mode_change_ack(struct ctlr_info *h) 
		spin_lock_irqsave(&h->lock, flags);

		doorbell_value = readl(h->vaddr + SA5_DOORBELL);

		spin_unlock_irqrestore(&h->lock, flags);

		if (!doorbell_value & CFGTBL_ChangeReq)

		if (!(doorbell_value & CFGTBL_ChangeReq))

			break;

		/* delay and try again */

		usleep_range(10000, 20000);