Commit 381cecc5 authored by Vitaly Kuznetsov's avatar Vitaly Kuznetsov Committed by Paolo Bonzini
Browse files

KVM: Drop 'except' parameter from kvm_make_vcpus_request_mask() 



Both remaining callers of kvm_make_vcpus_request_mask() pass 'NULL' for
'except' parameter so it can just be dropped.

No functional change intended ©.

Suggested-by: default avatarSean Christopherson <seanjc@google.com>
Reviewed-by: default avatarSean Christopherson <seanjc@google.com>
Signed-off-by: default avatarVitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Message-Id: <20210903075141.403071-6-vkuznets@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent ae0946cd

arch/x86/kvm/hyperv.c

+1 −1
Original line number Diff line number Diff line
@@ -1849,7 +1849,7 @@ static u64 kvm_hv_flush_tlb(struct kvm_vcpu *vcpu, struct kvm_hv_hcall *hc, bool 
						    vp_bitmap, vcpu_bitmap);



		kvm_make_vcpus_request_mask(kvm, KVM_REQ_TLB_FLUSH_GUEST,

					    NULL, vcpu_mask, &hv_vcpu->tlb_flush);

					    vcpu_mask, &hv_vcpu->tlb_flush);

	}



ret_success:

arch/x86/kvm/x86.c

+1 −1
Original line number Diff line number Diff line
@@ -9247,7 +9247,7 @@ void kvm_make_scan_ioapic_request_mask(struct kvm *kvm, 
	zalloc_cpumask_var(&cpus, GFP_ATOMIC);



	kvm_make_vcpus_request_mask(kvm, KVM_REQ_SCAN_IOAPIC,

				    NULL, vcpu_bitmap, cpus);

				    vcpu_bitmap, cpus);



	free_cpumask_var(cpus);

}

include/linux/kvm_host.h

+0 −1
Original line number Diff line number Diff line
@@ -160,7 +160,6 @@ static inline bool is_error_page(struct page *page) 
#define KVM_ARCH_REQ(nr)           KVM_ARCH_REQ_FLAGS(nr, 0)



bool kvm_make_vcpus_request_mask(struct kvm *kvm, unsigned int req,

				 struct kvm_vcpu *except,

				 unsigned long *vcpu_bitmap, cpumask_var_t tmp);

bool kvm_make_all_cpus_request(struct kvm *kvm, unsigned int req);

bool kvm_make_all_cpus_request_except(struct kvm *kvm, unsigned int req,

virt/kvm/kvm_main.c

+1 −2
Original line number Diff line number Diff line
@@ -288,7 +288,6 @@ static void kvm_make_vcpu_request(struct kvm *kvm, struct kvm_vcpu *vcpu, 
}



bool kvm_make_vcpus_request_mask(struct kvm *kvm, unsigned int req,

				 struct kvm_vcpu *except,

				 unsigned long *vcpu_bitmap, cpumask_var_t tmp)

{

	struct kvm_vcpu *vcpu;
@@ -299,7 +298,7 @@ bool kvm_make_vcpus_request_mask(struct kvm *kvm, unsigned int req, 


	for_each_set_bit(i, vcpu_bitmap, KVM_MAX_VCPUS) {

		vcpu = kvm_get_vcpu(kvm, i);

		if (!vcpu || vcpu == except)

		if (!vcpu)

			continue;

		kvm_make_vcpu_request(kvm, vcpu, req, tmp, me);

	}