Commit 381b6d7b authored by Martin Kaiser's avatar Martin Kaiser Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: assoc_rsp and assoc_rsp_len are not used 



The assoc_rsp buffer in struct mlme_priv is not used. There's no need to
store an incoming association response after receiving an processing it.

Remove the buffer pointer and its length from struct mlme_priv.

Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220515155401.352742-6-martin@kaiser.cx


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c8bff211

drivers/staging/r8188eu/core/rtw_mlme.c

+0 −1
Original line number Diff line number Diff line
@@ -40,7 +40,6 @@ static void rtw_free_mlme_ie_data(u8 **ppie, u32 *plen) 
void rtw_free_mlme_priv_ie_data(struct mlme_priv *pmlmepriv)

{

	kfree(pmlmepriv->assoc_req);

	kfree(pmlmepriv->assoc_rsp);

	rtw_free_mlme_ie_data(&pmlmepriv->wps_beacon_ie, &pmlmepriv->wps_beacon_ie_len);

	rtw_free_mlme_ie_data(&pmlmepriv->wps_probe_req_ie, &pmlmepriv->wps_probe_req_ie_len);

	rtw_free_mlme_ie_data(&pmlmepriv->wps_probe_resp_ie, &pmlmepriv->wps_probe_resp_ie_len);

drivers/staging/r8188eu/core/rtw_mlme_ext.c

+0 −6
Original line number Diff line number Diff line
@@ -1272,7 +1272,6 @@ unsigned int OnAssocRsp(struct adapter *padapter, struct recv_frame *precv_frame 
	int res;

	unsigned short	status;

	struct ndis_802_11_var_ie *pIE;

	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;

	struct mlme_ext_priv	*pmlmeext = &padapter->mlmeextpriv;

	struct mlme_ext_info	*pmlmeinfo = &pmlmeext->mlmext_info;

	/* struct wlan_bssid_ex *cur_network = &(pmlmeinfo->network); */
@@ -1343,11 +1342,6 @@ unsigned int OnAssocRsp(struct adapter *padapter, struct recv_frame *precv_frame 
	UpdateBrateTbl(padapter, pmlmeinfo->network.SupportedRates);



report_assoc_result:

	if (res > 0)

		rtw_buf_update(&pmlmepriv->assoc_rsp, &pmlmepriv->assoc_rsp_len, pframe, pkt_len);

	else

		kfree(pmlmepriv->assoc_rsp);



	report_join_res(padapter, res);



	return _SUCCESS;

drivers/staging/r8188eu/include/rtw_mlme.h

+0 −2
Original line number Diff line number Diff line
@@ -363,8 +363,6 @@ struct mlme_priv { 


	u8 *assoc_req;

	u32 assoc_req_len;

	u8 *assoc_rsp;

	u32 assoc_rsp_len;



	/* Number of associated Non-ERP stations (i.e., stations using 802.11b

	 * in 802.11g BSS) */