Commit 37fcfade authored by Hannes Reinecke's avatar Hannes Reinecke Committed by Damien Le Moal
Browse files

ata: sata_mv: kill 'port' argument in mv_dump_all_regs() 



Always '-1', so drop it and simplify the function.

Signed-off-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
parent 4633778b

drivers/ata/sata_mv.c

+6 −13
Original line number Diff line number Diff line
@@ -1280,24 +1280,17 @@ static void mv_dump_pci_cfg(struct pci_dev *pdev, unsigned bytes) 
#endif

}

#endif

static void mv_dump_all_regs(void __iomem *mmio_base, int port,

static void mv_dump_all_regs(void __iomem *mmio_base,

			     struct pci_dev *pdev)

{

#ifdef ATA_DEBUG

	void __iomem *hc_base = mv_hc_base(mmio_base,

					   port >> MV_PORT_HC_SHIFT);

	void __iomem *hc_base;

	void __iomem *port_base;

	int start_port, num_ports, p, start_hc, num_hcs, hc;



	if (0 > port) {

	start_hc = start_port = 0;

		num_ports = 8;		/* shld be benign for 4 port devs */

	num_ports = 8;		/* should be benign for 4 port devs */

	num_hcs = 2;

	} else {

		start_hc = port >> MV_PORT_HC_SHIFT;

		start_port = port;

		num_ports = num_hcs = 1;

	}

	DPRINTK("All registers for port(s) %u-%u:\n", start_port,

		num_ports > 1 ? num_ports - 1 : start_port);
@@ -2963,7 +2956,7 @@ static int mv_pci_error(struct ata_host *host, void __iomem *mmio) 
	dev_err(host->dev, "PCI ERROR; PCI IRQ cause=0x%08x\n", err_cause);



	DPRINTK("All regs @ PCI error\n");

	mv_dump_all_regs(mmio, -1, to_pci_dev(host->dev));

	mv_dump_all_regs(mmio, to_pci_dev(host->dev));



	writelfl(0, mmio + hpriv->irq_cause_offset);