Commit 37ed76a7 authored by Maximilian Luz's avatar Maximilian Luz Committed by Hans de Goede
Browse files

platform/surface: aggregator: Do not return uninitialized value 



The status variable in ssam_nf_refcount_disable_free() is only set when
the reference count equals zero. Otherwise, it is returned
uninitialized. Fix this by always initializing status to zero.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Fixes: 640ee17199e4 ("platform/surface: aggregator: Allow enabling of events without notifiers")
Signed-off-by: default avatarMaximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/20210604210907.25738-2-luzmaximilian@gmail.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 8ae20054

drivers/platform/surface/aggregator/controller.c

+1 −1
Original line number Diff line number Diff line
@@ -2228,7 +2228,7 @@ static int ssam_nf_refcount_disable_free(struct ssam_controller *ctrl, 
	const struct ssam_event_registry reg = entry->key.reg;

	const struct ssam_event_id id = entry->key.id;

	struct ssam_nf *nf = &ctrl->cplt.event.notif;

	int status;

	int status = 0;



	lockdep_assert_held(&nf->lock);