Commit 37c5f9e8 authored by Oleksandr Ocheretnyi's avatar Oleksandr Ocheretnyi Committed by Miquel Raynal
Browse files

mtd: fix 'part' field data corruption in mtd_info 



Commit 46b5889c ("mtd: implement proper partition handling")
started using "mtd_get_master_ofs()" in mtd callbacks to determine
memory offsets by means of 'part' field from mtd_info, what previously
was smashed accessing 'master' field in the mtd_set_dev_defaults() method.
That provides wrong offset what causes hardware access errors.

Just make 'part', 'master' as separate fields, rather than using
union type to avoid 'part' data corruption when mtd_set_dev_defaults()
is called.

Fixes: 46b5889c ("mtd: implement proper partition handling")
Signed-off-by: default avatarOleksandr Ocheretnyi <oocheret@cisco.com>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20220417184649.449289-1-oocheret@cisco.com
parent 084c16ab

include/linux/mtd/mtd.h

+2 −4
Original line number Diff line number Diff line
@@ -389,11 +389,9 @@ struct mtd_info { 
	/* List of partitions attached to this MTD device */

	struct list_head partitions;



	union {

	struct mtd_part part;

	struct mtd_master master;

};

};



static inline struct mtd_info *mtd_get_master(struct mtd_info *mtd)

{