Commit 37b85bd5 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

drivers: vmw_balloon: remove dentry pointer for debugfs 



There is no need to keep the dentry pointer around for the created
debugfs file, as it is only needed when removing it from the system.
When it is to be removed, ask debugfs itself for the pointer, to save on
storage and make things a bit simpler.

Cc: Nadav Amit <namit@vmware.com>
Cc: "VMware, Inc." <pv-drivers@vmware.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org
Acked-by: default avatarNadav Amit <namit@vmware.com>
Link: https://lore.kernel.org/r/20210216151209.3954129-1-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fb11de92

drivers/misc/vmw_balloon.c

+3 −8
Original line number Diff line number Diff line
@@ -346,11 +346,6 @@ struct vmballoon { 
	/* statistics */

	struct vmballoon_stats *stats;



#ifdef CONFIG_DEBUG_FS

	/* debugfs file exporting statistics */

	struct dentry *dbg_entry;

#endif



	/**

	 * @b_dev_info: balloon device information descriptor.

	 */
@@ -1709,14 +1704,14 @@ DEFINE_SHOW_ATTRIBUTE(vmballoon_debug); 


static void __init vmballoon_debugfs_init(struct vmballoon *b)

{

	b->dbg_entry = debugfs_create_file("vmmemctl", S_IRUGO, NULL, b,

	debugfs_create_file("vmmemctl", S_IRUGO, NULL, b,

			    &vmballoon_debug_fops);

}



static void __exit vmballoon_debugfs_exit(struct vmballoon *b)

{

	static_key_disable(&balloon_stat_enabled.key);

	debugfs_remove(b->dbg_entry);

	debugfs_remove(debugfs_lookup("vmmemctl", NULL));

	kfree(b->stats);

	b->stats = NULL;

}