Commit 37ae5a0f authored by Tetsuo Handa's avatar Tetsuo Handa Committed by Jens Axboe
Browse files

block: use "unsigned long" for blk_validate_block_size(). 



Since lo_simple_ioctl(LOOP_SET_BLOCK_SIZE) and ioctl(NBD_SET_BLKSIZE) pass
user-controlled "unsigned long arg" to blk_validate_block_size(),
"unsigned long" should be used for validation.

Signed-off-by: default avatarTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/9ecbf057-4375-c2db-ab53-e4cc0dff953d@i-love.sakura.ne.jp


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 99d8690a

include/linux/blkdev.h

+1 −1
Original line number Diff line number Diff line
@@ -45,7 +45,7 @@ struct blk_crypto_profile; 
 */

#define BLKCG_MAX_POLS		6



static inline int blk_validate_block_size(unsigned int bsize)

static inline int blk_validate_block_size(unsigned long bsize)

{

	if (bsize < 512 || bsize > PAGE_SIZE || !is_power_of_2(bsize))

		return -EINVAL;