Commit 379091e0 authored by Sui Jingfeng's avatar Sui Jingfeng Committed by Chun-Kuang Hu
Browse files

drm/mediatek: Fix potential memory leak if vmap() fail 



Also return -ENOMEM if such a failure happens, the implement should take
responsibility for the error handling.

Fixes: 3df64d7b ("drm/mediatek: Implement gem prime vmap/vunmap function")
Reviewed-by: default avatarMatthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: default avatarAlexandre Mergnat <amergnat@baylibre.com>
Signed-off-by: default avatarSui Jingfeng <suijingfeng@loongson.cn>
Reviewed-by: default avatarCK Hu <ck.hu@mediatek.com>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://patchwork.kernel.org/project/dri-devel/patch/20230706134000.130098-1-suijingfeng@loongson.cn/


Signed-off-by: default avatarChun-Kuang Hu <chunkuang.hu@kernel.org>
parent ed6adfb7

drivers/gpu/drm/mediatek/mtk_drm_gem.c

+5 −1
Original line number Diff line number Diff line
@@ -247,7 +247,11 @@ int mtk_drm_gem_prime_vmap(struct drm_gem_object *obj, struct iosys_map *map) 


	mtk_gem->kvaddr = vmap(mtk_gem->pages, npages, VM_MAP,

			       pgprot_writecombine(PAGE_KERNEL));



	if (!mtk_gem->kvaddr) {

		kfree(sgt);

		kfree(mtk_gem->pages);

		return -ENOMEM;

	}

out:

	kfree(sgt);

	iosys_map_set_vaddr(map, mtk_gem->kvaddr);