Commit 378876b0 authored by Miaohe Lin's avatar Miaohe Lin Committed by Linus Torvalds
Browse files

mm: memcontrol: eliminate redundant check in __mem_cgroup_insert_exceeded() 

The mz->usage_in_excess >= mz_node->usage_in_excess check is exactly the
else case of mz->usage_in_excess < mz_node->usage_in_excess.  So we could
replace else if (mz->usage_in_excess >= mz_node->usage_in_excess) with
else equally.  Also drop the comment which doesn't really explain much.

Link: https://lkml.kernel.org/r/20201012131607.10656-1-linmiaohe@huawei.com


Signed-off-by: default avatarMiaohe Lin <linmiaohe@huawei.com>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Acked-by: default avatarJohannes Weiner <hannes@cmpxchg.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 1a984c4e

mm/memcontrol.c

+2 −7
Original line number Diff line number Diff line
@@ -623,15 +623,10 @@ static void __mem_cgroup_insert_exceeded(struct mem_cgroup_per_node *mz, 
		if (mz->usage_in_excess < mz_node->usage_in_excess) {

			p = &(*p)->rb_left;

			rightmost = false;

		}



		/*

		 * We can't avoid mem cgroups that are over their soft

		 * limit by the same amount

		 */

		else if (mz->usage_in_excess >= mz_node->usage_in_excess)

		} else {

			p = &(*p)->rb_right;

		}

	}



	if (rightmost)

		mctz->rb_rightmost = &mz->tree_node;