Commit 37870358 authored by Dan Carpenter's avatar Dan Carpenter Committed by Bartosz Golaszewski
Browse files

gpio: mxc: Unlock on error path in mxc_flip_edge() 



We recently added locking to this function but one error path was
over looked.  Drop the lock before returning.

Fixes: e5464277 ("gpio: mxc: Protect GPIO irqchip RMW with bgpio spinlock")
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Acked-by: default avatarMarek Vasut <marex@denx.de>
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent d63f11c0

drivers/gpio/gpio-mxc.c

+2 −1
Original line number Diff line number Diff line
@@ -249,10 +249,11 @@ static void mxc_flip_edge(struct mxc_gpio_port *port, u32 gpio) 
	} else {

		pr_err("mxc: invalid configuration for GPIO %d: %x\n",

		       gpio, edge);

		return;

		goto unlock;

	}

	writel(val | (edge << (bit << 1)), reg);



unlock:

	raw_spin_unlock_irqrestore(&port->gc.bgpio_lock, flags);

}