Commit 377f8331 authored by xndcn's avatar xndcn Committed by Gerd Hoffmann
Browse files

drm/virtio: fix possible leak/unlock virtio_gpu_object_array 



virtio_gpu_object array is not freed or unlocked in some
failed cases.

Signed-off-by: default avatarxndcn <xndchn@gmail.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20210305151819.14330-1-xndchn@gmail.com


Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent edf20859

drivers/gpu/drm/virtio/virtgpu_ioctl.c

+1 −1
Original line number Diff line number Diff line
@@ -174,7 +174,7 @@ static int virtio_gpu_execbuffer_ioctl(struct drm_device *dev, void *data, 
		if (!sync_file) {

			dma_fence_put(&out_fence->f);

			ret = -ENOMEM;

			goto out_memdup;

			goto out_unresv;

		}



		exbuf->fence_fd = out_fence_fd;

drivers/gpu/drm/virtio/virtgpu_object.c

+1 −0
Original line number Diff line number Diff line
@@ -248,6 +248,7 @@ int virtio_gpu_object_create(struct virtio_gpu_device *vgdev, 


	ret = virtio_gpu_object_shmem_init(vgdev, bo, &ents, &nents);

	if (ret != 0) {

		virtio_gpu_array_put_free(objs);

		virtio_gpu_free_object(&shmem_obj->base);

		return ret;

	}