Commit 3727f03e authored by James Clark's avatar James Clark Committed by Mathieu Poirier
Browse files

coresight: Remove unused function parameter 



The ability to use a custom function in this sysfs show function isn't
used so remove it.

No functional changes.

Signed-off-by: default avatarJames Clark <james.clark@arm.com>
Reviewed-by: default avatarMike Leach <mike.leach@linaro.org>
Link: https://lore.kernel.org/r/20220830172614.340962-2-james.clark@arm.com


Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
parent 04d1edb0

drivers/hwtracing/coresight/coresight-priv.h

+4 −12
Original line number Diff line number Diff line
@@ -40,31 +40,23 @@ 
#define ETM_MODE_EXCL_KERN	BIT(30)

#define ETM_MODE_EXCL_USER	BIT(31)



typedef u32 (*coresight_read_fn)(const struct device *, u32 offset);

#define __coresight_simple_func(type, func, name, lo_off, hi_off)	\

#define __coresight_simple_show(type, name, lo_off, hi_off)		\

static ssize_t name##_show(struct device *_dev,				\

			   struct device_attribute *attr, char *buf)	\

{									\

	type *drvdata = dev_get_drvdata(_dev->parent);			\

	coresight_read_fn fn = func;					\

	u64 val;							\

	pm_runtime_get_sync(_dev->parent);				\

	if (fn)								\

		val = (u64)fn(_dev->parent, lo_off);			\

	else								\

		val = coresight_read_reg_pair(drvdata->base,		\

						 lo_off, hi_off);	\

	val = coresight_read_reg_pair(drvdata->base, lo_off, hi_off);	\

	pm_runtime_put_sync(_dev->parent);				\

	return scnprintf(buf, PAGE_SIZE, "0x%llx\n", val);		\

}									\

static DEVICE_ATTR_RO(name)



#define coresight_simple_func(type, func, name, offset)			\

	__coresight_simple_func(type, func, name, offset, -1)

#define coresight_simple_reg32(type, name, offset)			\

	__coresight_simple_func(type, NULL, name, offset, -1)

	__coresight_simple_show(type, name, offset, -1)

#define coresight_simple_reg64(type, name, lo_off, hi_off)		\

	__coresight_simple_func(type, NULL, name, lo_off, hi_off)

	__coresight_simple_show(type, name, lo_off, hi_off)



extern const u32 coresight_barrier_pkt[4];

#define CORESIGHT_BARRIER_PKT_SIZE (sizeof(coresight_barrier_pkt))