Commit 370e3d5b authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Greg Kroah-Hartman
Browse files

usb: dwc3: keystone: Simplify with dev_err_probe() 



Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.

Acked-by: default avatarFelipe Balbi <balbi@kernel.org>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20210111135539.57234-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 49d08cfc

drivers/usb/dwc3/dwc3-keystone.c

+2 −7
Original line number Diff line number Diff line
@@ -99,13 +99,8 @@ static int kdwc3_probe(struct platform_device *pdev) 


	/* PSC dependency on AM65 needs SERDES0 to be powered before USB0 */

	kdwc->usb3_phy = devm_phy_optional_get(dev, "usb3-phy");

	if (IS_ERR(kdwc->usb3_phy)) {

		error = PTR_ERR(kdwc->usb3_phy);

		if (error != -EPROBE_DEFER)

			dev_err(dev, "couldn't get usb3 phy: %d\n", error);



		return error;

	}

	if (IS_ERR(kdwc->usb3_phy))

		return dev_err_probe(dev, PTR_ERR(kdwc->usb3_phy), "couldn't get usb3 phy\n");



	phy_pm_runtime_get_sync(kdwc->usb3_phy);