Commit 37081aed authored by Yangyang Li's avatar Yangyang Li Committed by Juan Zhou
Browse files

RDMA/hns: Use macro instead of magic number 

maillist inclusion
category: feature
bugzilla: https://gitee.com/openeuler/kernel/issues/I9HASN
CVE: NA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bfb6be401470206ac02cbfdaf7b76ee040c1ae3d



----------------------------------------------------------------------

Use macro instead of magic number.

Signed-off-by: default avatarYangyang Li <liyangyang20@huawei.com>
Signed-off-by: default avatarChengchang Tang <tangchengchang@huawei.com>
Signed-off-by: default avatarJunxian Huang <huangjunxian6@hisilicon.com>
Link: https://lore.kernel.org/r/20240412091616.370789-2-huangjunxian6@hisilicon.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarJuan Zhou <zhoujuan51@h-partners.com>
parent e955f4f5

drivers/infiniband/hw/hns/hns_roce_hw_v2.c

+19 −15
Original line number Diff line number Diff line
@@ -3433,13 +3433,14 @@ static int set_mtpt_pbl(struct hns_roce_dev *hr_dev, 


	/* Aligned to the hardware address access unit */

	for (i = 0; i < ARRAY_SIZE(pages); i++)

		pages[i] >>= 6;

		pages[i] >>= MPT_PBL_BUF_ADDR_S;



	pbl_ba = hns_roce_get_mtr_ba(&mr->pbl_mtr);



	mpt_entry->pbl_size = cpu_to_le32(mr->npages);

	mpt_entry->pbl_ba_l = cpu_to_le32(pbl_ba >> 3);

	hr_reg_write(mpt_entry, MPT_PBL_BA_H, upper_32_bits(pbl_ba >> 3));

	mpt_entry->pbl_ba_l = cpu_to_le32(pbl_ba >> MPT_PBL_BA_ADDR_S);

	hr_reg_write(mpt_entry, MPT_PBL_BA_H,

		     upper_32_bits(pbl_ba >> MPT_PBL_BA_ADDR_S));



	mpt_entry->pa0_l = cpu_to_le32(lower_32_bits(pages[0]));

	hr_reg_write(mpt_entry, MPT_PA0_H, upper_32_bits(pages[0]));
@@ -3560,8 +3561,10 @@ static int hns_roce_v2_frmr_write_mtpt(struct hns_roce_dev *hr_dev, 


	mpt_entry->pbl_size = cpu_to_le32(mr->npages);



	mpt_entry->pbl_ba_l = cpu_to_le32(lower_32_bits(pbl_ba >> 3));

	hr_reg_write(mpt_entry, MPT_PBL_BA_H, upper_32_bits(pbl_ba >> 3));

	mpt_entry->pbl_ba_l = cpu_to_le32(lower_32_bits(pbl_ba >>

							MPT_PBL_BA_ADDR_S));

	hr_reg_write(mpt_entry, MPT_PBL_BA_H,

		     upper_32_bits(pbl_ba >> MPT_PBL_BA_ADDR_S));



	return 0;

}
@@ -3808,14 +3811,14 @@ static void hns_roce_v2_write_cqc(struct hns_roce_dev *hr_dev, 
		     to_hr_hw_page_shift(hr_cq->mtr.hem_cfg.ba_pg_shift));

	hr_reg_write(cq_context, CQC_CQE_BUF_PG_SZ,

		     to_hr_hw_page_shift(hr_cq->mtr.hem_cfg.buf_pg_shift));

	hr_reg_write(cq_context, CQC_CQE_BA_L, dma_handle >> 3);

	hr_reg_write(cq_context, CQC_CQE_BA_H, (dma_handle >> (32 + 3)));

	hr_reg_write(cq_context, CQC_CQE_BA_L, dma_handle >> CQC_CQE_BA_L_S);

	hr_reg_write(cq_context, CQC_CQE_BA_H, dma_handle >> CQC_CQE_BA_H_S);

	hr_reg_write_bool(cq_context, CQC_DB_RECORD_EN,

			  hr_cq->flags & HNS_ROCE_CQ_FLAG_RECORD_DB);

	hr_reg_write(cq_context, CQC_CQE_DB_RECORD_ADDR_L,

		     ((u32)hr_cq->db.dma) >> 1);

	hr_reg_write(cq_context, CQC_CQE_DB_RECORD_ADDR_H,

		     hr_cq->db.dma >> 32);

		     hr_cq->db.dma >> CQC_CQE_DB_RECORD_ADDR_H_S);

	hr_reg_write(cq_context, CQC_CQ_MAX_CNT,

		     HNS_ROCE_V2_CQ_DEFAULT_BURST_NUM);

	hr_reg_write(cq_context, CQC_CQ_PERIOD,
@@ -4755,11 +4758,11 @@ static int modify_qp_init_to_rtr(struct ib_qp *ibqp, 
		return -EINVAL;

	}



	hr_reg_write(context, QPC_TRRL_BA_L, trrl_ba >> 4);

	hr_reg_write(context, QPC_TRRL_BA_L, trrl_ba >> QPC_TRRL_BA_L_S);

	hr_reg_clear(qpc_mask, QPC_TRRL_BA_L);

	context->trrl_ba = cpu_to_le32(trrl_ba >> (16 + 4));

	context->trrl_ba = cpu_to_le32(trrl_ba >> QPC_TRRL_BA_M_S);

	qpc_mask->trrl_ba = 0;

	hr_reg_write(context, QPC_TRRL_BA_H, trrl_ba >> (32 + 16 + 4));

	hr_reg_write(context, QPC_TRRL_BA_H, trrl_ba >> QPC_TRRL_BA_H_S);

	hr_reg_clear(qpc_mask, QPC_TRRL_BA_H);



	if (hr_dev->pci_dev->revision >= PCI_REVISION_ID_HIP09) {
@@ -4772,9 +4775,9 @@ static int modify_qp_init_to_rtr(struct ib_qp *ibqp, 
		hr_reg_clear(qpc_mask, QPC_V2_IRRL_HEAD);

	}



	context->irrl_ba = cpu_to_le32(irrl_ba >> 6);

	context->irrl_ba = cpu_to_le32(irrl_ba >> QPC_IRRL_BA_L_S);

	qpc_mask->irrl_ba = 0;

	hr_reg_write(context, QPC_IRRL_BA_H, irrl_ba >> (32 + 6));

	hr_reg_write(context, QPC_IRRL_BA_H, irrl_ba >> QPC_IRRL_BA_H_S);

	hr_reg_clear(qpc_mask, QPC_IRRL_BA_H);



	hr_reg_enable(context, QPC_RMT_E2E);
@@ -4836,8 +4839,9 @@ static int modify_qp_init_to_rtr(struct ib_qp *ibqp, 
	hr_reg_clear(qpc_mask, QPC_TRRL_HEAD_MAX);

	hr_reg_clear(qpc_mask, QPC_TRRL_TAIL_MAX);



#define MAX_LP_SGEN 3

	/* rocee send 2^lp_sgen_ini segs every time */

	hr_reg_write(context, QPC_LP_SGEN_INI, 3);

	hr_reg_write(context, QPC_LP_SGEN_INI, MAX_LP_SGEN);

	hr_reg_clear(qpc_mask, QPC_LP_SGEN_INI);



	if (udata && ibqp->qp_type == IB_QPT_RC &&
@@ -4929,7 +4933,7 @@ static int get_dip_ctx_idx(struct ib_qp *ibqp, const struct ib_qp_attr *attr, 
	*tail = (*tail == hr_dev->caps.num_qps - 1) ? 0 : (*tail + 1);



	list_for_each_entry(hr_dip, &hr_dev->dip_list, node) {

		if (!memcmp(grh->dgid.raw, hr_dip->dgid, 16)) {

		if (!memcmp(grh->dgid.raw, hr_dip->dgid, GID_LEN_V2)) {

			*dip_idx = hr_dip->dip_idx;

			goto out;

		}

drivers/infiniband/hw/hns/hns_roce_hw_v2.h

+13 −0
Original line number Diff line number Diff line
@@ -284,6 +284,10 @@ struct hns_roce_v2_cq_context { 
	__le32 byte_64_se_cqe_idx;

};



#define CQC_CQE_BA_L_S 3

#define CQC_CQE_BA_H_S (32 + CQC_CQE_BA_L_S)

#define CQC_CQE_DB_RECORD_ADDR_H_S 32



#define HNS_ROCE_V2_CQ_DEFAULT_BURST_NUM 0x0

#define HNS_ROCE_V2_CQ_DEFAULT_INTERVAL	0x0
@@ -455,6 +459,12 @@ struct hns_roce_v2_qp_context { 
	struct hns_roce_v2_qp_context_ex ext;

};



#define QPC_TRRL_BA_L_S 4

#define QPC_TRRL_BA_M_S (16 + QPC_TRRL_BA_L_S)

#define QPC_TRRL_BA_H_S (32 + QPC_TRRL_BA_M_S)

#define QPC_IRRL_BA_L_S 6

#define QPC_IRRL_BA_H_S (32 + QPC_IRRL_BA_L_S)



#define QPC_FIELD_LOC(h, l) FIELD_LOC(struct hns_roce_v2_qp_context, h, l)



#define QPC_TST QPC_FIELD_LOC(2, 0)
@@ -724,6 +734,9 @@ struct hns_roce_v2_mpt_entry { 
	__le32	byte_64_buf_pa1;

};



#define MPT_PBL_BUF_ADDR_S 6

#define MPT_PBL_BA_ADDR_S 3



#define MPT_FIELD_LOC(h, l) FIELD_LOC(struct hns_roce_v2_mpt_entry, h, l)



#define MPT_ST MPT_FIELD_LOC(1, 0)

drivers/infiniband/hw/hns/hns_roce_qp.c

+2 −1
Original line number Diff line number Diff line
@@ -416,7 +416,8 @@ static void free_qpn(struct hns_roce_dev *hr_dev, struct hns_roce_qp *hr_qp) 


	bankid = get_qp_bankid(hr_qp->qpn);



	ida_free(&hr_dev->qp_table.bank[bankid].ida, hr_qp->qpn >> 3);

	ida_free(&hr_dev->qp_table.bank[bankid].ida,

		 hr_qp->qpn / HNS_ROCE_QP_BANK_NUM);



	mutex_lock(&hr_dev->qp_table.bank_mutex);

	hr_dev->qp_table.bank[bankid].inuse--;